Navigation: Fix issue creating front-end markup#18607
Merged
Conversation
getdave
approved these changes
Nov 19, 2019
draganescu
approved these changes
Nov 19, 2019
Contributor
draganescu
left a comment
There was a problem hiding this comment.
All attributes should go through esc_attr indeed :)
fea84ee to
7c8b33f
Compare
obenland
requested changes
Nov 19, 2019
obenland
approved these changes
Nov 19, 2019
It fixes a big when the link has spececial chars escaping them applying the esc_attr() function
3273d9e to
760f0a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It fixes a bug when the link has special chars escaping them applying the esc_attr() function.
Fixes #18604
How has this been tested?
Add a link from a post or page where its menu has a special char, for instance
<,>, etcBefore
Confirm that it breaks the markup in the front-end:
After
The markup should be ok.
Screenshots
Checklist: