[Monorepo] Fix iOS build#18566
Merged
hypest merged 8 commits intofeat/import-gutenberg-mobile-no-squashfrom Mar 27, 2020
Merged
[Monorepo] Fix iOS build#18566hypest merged 8 commits intofeat/import-gutenberg-mobile-no-squashfrom
hypest merged 8 commits intofeat/import-gutenberg-mobile-no-squashfrom
Conversation
gziolo
reviewed
Nov 26, 2019
6 tasks
gziolo
reviewed
Dec 6, 2019
3cd469e to
d7c54c9
Compare
|
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
Tug
approved these changes
Mar 26, 2020
Contributor
Tug
left a comment
There was a problem hiding this comment.
LGTM 👍
XCode wasn't able to launch the metro server though, is this something we can fix? I had the same problem for the android PR but sadly I figured this is due to a bug in a react-native script, might be the same bug actually
Member
The script to start the packager is not present in the Xcode project. But it's also not present in gutenberg-mobile's Xcode project. Could it be that it didn't launch the metro server before as well? |
Contributor
Most probably 👍 Anyway it's consistent with android's behavior! Let's ship, but please don't merge yourself, @hypest has to in order to retain the history! |
ceyhun
previously approved these changes
Mar 26, 2020
…squash' into rnmobile/import-mobile-fix-build-ios
Contributor
|
Merging this with "merge commit" option on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a part of migration gutenberg-mobile to gutenberg repo.
In this PR I fixed iOS build of
react-native-editorexample app. In order to do that, I had to change paths to linked libraries in the iOS project and change paths where we search for headers.I also changed
rn-cli.config.jswhere I addedwatchFoldersfield withnode_modulesfrom the root level and allpackagesand removedrn-cl-inside-gb.config.jssince it is not needed anymore.The last thing is the fix for
sass-transformer.jsand removingsass-transformer-inside-gb.jsHow has this been tested?
npm run native bundle:iosshould create a JS bundlenpm run native iosshould start iOS example appScreenshots
Types of changes
Fix the iOS build in imported
react-native-editorpackageChecklist: