Adds in a styled drop down default#18491
Closed
karmatosed wants to merge 1 commit into
Closed
Conversation
It should be discussed if this is by default or not for subnav. It could be a style or it could be one we add by default. I have styled it dark but we could also go with white as an option, which might work better across all text colors.
retrofox
reviewed
Nov 15, 2019
Comment on lines
120
to
+123
| // Disable reason: This function call looks nicer when each argument is on its own line. | ||
| /* stylelint-disable */ | ||
| background-image: linear-gradient( | ||
| -45deg, | ||
| theme(button) 28%, | ||
| color(theme(button) shade(20%)) 28%, | ||
| color(theme(button) shade(20%)) 72%, | ||
| theme(button) 72% | ||
| ); | ||
| background-image: | ||
| linear-gradient(-45deg, theme(button) 28%, color(theme(button) shade(20%)) 28%, color(theme(button) shade(20%)) 72%, theme(button) 72%); |
Contributor
There was a problem hiding this comment.
If we are going to reorganize the background-image in only one line then we should remove the comment which disables the style lint rule:
Member
Author
|
Closing as moving to having style variations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be discussed if this is by default or not for subnav. It could be a style or it could be one we add by default.
I have styled it dark but we could also go with white as an option, which might work better across all text colors.