Navigation Menu: render item without link#18442
Closed
retrofox wants to merge 11 commits into
Closed
Conversation
6 tasks
obenland
requested changes
Nov 12, 2019
obenland
left a comment
Member
There was a problem hiding this comment.
All values being output into an element attribute need to be run through esc_attr().
tellthemachines
requested changes
Nov 13, 2019
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this! Just a few fairly minor comments/questions below.
ef26329 to
1a980dd
Compare
draganescu
requested changes
Nov 13, 2019
draganescu
reviewed
Nov 14, 2019
If we end up going with a different term, at least we'll have a better idea what it all is that needs updating.
It handles the case when the item has not defined a linl, rendering the item with an <span> element instrad of an anchor <a>.
4d61148 to
8c5bc36
Compare
37 tasks
Contributor
|
@retrofox is this one outdated now that we have a placeholder state for empty menu items?
|
Contributor
Author
Yeah, pretty sure it is! let me close it. Thanks for the ping 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It handles the case when the item has not defined a link, rendering the item with a
<span>element instead of an anchor<a>.Description
How has this been tested?
Add an item without a link from the Editor canvas.
Confirm the markup sets an anchor element to those items that have defined a link, and sets a element when there aren't. Pay attention to the CSS class as well.
Screenshots
Types of changes
Checklist: