Components: Switch screen-reader-text to VisuallyHidden#18165
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the follow up PR from comment in #18127 it addresses changing the other spots in components that use
screen-reader-textto usingVisuallyHiddencomponent.The two spots changed are:
base-controlandform-text-tokenHow has this been tested?
I created a story in Storybook to be committed in separate PR and confirmed that using the component shows the label as intended,
Types of changes
In essence it changes
<span className="screen-reader-text"> ... </span>to<VisuallyHidden> ... </VisuallyHidden>The base-control change uses label, and had a bit more logic wrapped around it.
Checklist: