Skip to content

Playground: Only build design system once.#17818

Closed
epiqueras wants to merge 1 commit into
masterfrom
fix/playground-build
Closed

Playground: Only build design system once.#17818
epiqueras wants to merge 1 commit into
masterfrom
fix/playground-build

Conversation

@epiqueras

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue where the design system was being built twice, due to the relevant script being called explicitly in Travis right after another script, the playground build, that included it.

This also caused problems with how the playground is built on Travis, because it uses the argument appending functionality of npm scripts to pass the public URL that should be used. This meant that the parameter was being received by the last script, the design system build, instead of the playground build as intended.

How has this been tested?

It was verified that the playground can be built and served.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@epiqueras epiqueras added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Build Tooling Issues or PRs related to build tooling [Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components labels Oct 7, 2019
@epiqueras epiqueras added this to the Future milestone Oct 7, 2019
@epiqueras epiqueras self-assigned this Oct 7, 2019
@epiqueras

Copy link
Copy Markdown
Contributor Author

Already done in #17762.

@epiqueras epiqueras closed this Oct 9, 2019
@aristath aristath deleted the fix/playground-build branch November 10, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] UI Components Impacts or related to the UI component system Framework Issues related to broader framework topics, especially as it relates to javascript [Package] Components /packages/components [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants