Skip to content

[RNMobile] Adjust FloatingToolbar to first shippable temporary version#17811

Closed
lukewalczak wants to merge 10 commits intoWordPress:masterfrom
callstack:rnmobile/temporary-shippable-floating-toolbar
Closed

[RNMobile] Adjust FloatingToolbar to first shippable temporary version#17811
lukewalczak wants to merge 10 commits intoWordPress:masterfrom
callstack:rnmobile/temporary-shippable-floating-toolbar

Conversation

@lukewalczak
Copy link
Copy Markdown
Member

@lukewalczak lukewalczak commented Oct 7, 2019 •
edited
Loading

Description

Fixes: wordpress-mobile/gutenberg-mobile#1413
Ref to gb-mobile repo: wordpress-mobile/gutenberg-mobile#1419

How has this been tested?

Tested on both platforms:

  1. Add a Group
  2. Add any block inside a Group
  3. Notice the FloatingToolbar

Screenshots

Will be added soon. --> added below.

Types of changes

Render FloatingToolbar over the item but without overlapping.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@lukewalczak lukewalczak mentioned this pull request Oct 7, 2019
Closed
1 task
@lukewalczak
Copy link
Copy Markdown
Member Author

lukewalczak commented Oct 8, 2019

@pinarol @iamthomasbishop for testing purpose I've merged locally @jbinda changes from branch rnmobile/navigate-down (keep in mind that his PR is still in progress) to present you how FloatingToolbar is going to look like and behave with borders.

screenshot gif
Screenshot 2019-10-08 at 14 42 42

Please let me know if you need more gifs/screenshots etc. Thanks!

@pinarol pinarol added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Design Feedback Needs general design feedback. labels Oct 8, 2019
@iamthomasbishop
Copy link
Copy Markdown

iamthomasbishop commented Oct 8, 2019

This looks pretty good for the first temp. version. One small request before we ship: can we add 8px (or 4px if this is 8 much) margin above/below the floating toolbar?

I have the previously-discussed concerns about spacing/margins but I'm guessing we'll tackle that separately.

@lukewalczak
Copy link
Copy Markdown
Member Author

lukewalczak commented Oct 9, 2019

@iamthomasbishop Thanks for feedback! I've added margin-bottom: 8px to FloatingToolbar

Screenshot 2019-10-09 at 10 53 13

This was referenced Oct 9, 2019
Closed
Closed
Closed
@iamthomasbishop
Copy link
Copy Markdown

iamthomasbishop commented Oct 9, 2019

Awesome, looking good and thank you!

@lukewalczak lukewalczak mentioned this pull request Oct 15, 2019
Merged
5 tasks
@lukewalczak
Copy link
Copy Markdown
Member Author

lukewalczak commented Oct 15, 2019

Closing - Functionality was move into the PR.

@lukewalczak lukewalczak mentioned this pull request Oct 15, 2019
Merged
1 task
@pinarol pinarol mentioned this pull request Oct 15, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkevins mkevins mkevins left review comments

Assignees

@lukewalczak lukewalczak

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Design Feedback Needs general design feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FloatingToolbar 1st shippable version

4 participants

@lukewalczak @iamthomasbishop @mkevins @pinarol