Skip to content

Tests: Try to stabilize e2e test with concurrent local and server autosave#17749

Closed
gziolo wants to merge 2 commits into
masterfrom
try/e2e-test-autosave-fix
Closed

Tests: Try to stabilize e2e test with concurrent local and server autosave#17749
gziolo wants to merge 2 commits into
masterfrom
try/e2e-test-autosave-fix

Conversation

@gziolo

@gziolo gziolo commented Oct 3, 2019

Copy link
Copy Markdown
Member

Description

Follow-up for #17679.

@gziolo gziolo added [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Oct 3, 2019
@gziolo gziolo requested a review from mcsf October 3, 2019 13:56
@gziolo gziolo self-assigned this Oct 3, 2019
@gziolo gziolo force-pushed the try/e2e-test-autosave-fix branch from 35bc7ee to cc59a69 Compare October 3, 2019 15:38
@gziolo

gziolo commented Oct 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Huh, it failed here: https://travis-ci.com/WordPress/gutenberg/jobs/241733934

We might want to play with intercepting requests similar to what was implemented here:

gutenberg/packages/e2e-tests/specs/change-detection.test.js

Lines 47 to 58 in 98f2a5a

async function interceptSave() {
await page.setRequestInterception( true );
handleInterceptedRequest = ( interceptedRequest ) => {
if ( interceptedRequest.url().includes( '/wp/v2/posts' ) ) {
hadInterceptedSave = true;
} else {
interceptedRequest.continue();
}
};
page.on( 'request', handleInterceptedRequest );
}

@mcsf

mcsf commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

Huh, it failed here: https://travis-ci.com/WordPress/gutenberg/jobs/241733934

Thanks for digging. It does seem, more and more, that there may be something wrong with autosave (server-side) itself.

@gziolo gziolo mentioned this pull request Oct 3, 2019
Merged
5 tasks
@gziolo gziolo closed this Oct 9, 2019
@gziolo gziolo deleted the try/e2e-test-autosave-fix branch October 9, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcsf mcsf Awaiting requested review from mcsf

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@talldan talldan Awaiting requested review from talldan

Assignees

@gziolo gziolo

Labels

[Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gziolo @mcsf