[Monorepo] Import gutenberg-mobile as new WordPress react-native packages#17456
[Monorepo] Import gutenberg-mobile as new WordPress react-native packages#17456
Conversation
|
I love it ❤️ How can I help to merge it? Will we have to split it into more PRs? Do you need my review now or is it mostly an experiment? |
I'm thinking test and report bugs and other problems! Also there is going to be a lot of work needed around integrating the new packages with the current ones in terms of scripts, build, lint checks, doc gen, package release... obviously we cannot do everything at once but I expect this PR not to break anything either on the web or the mobile side.
I'd like to but I'm not sure how at this point, most added files depend on each others at the moment... ideas are welcomed here 👍
It's mostly an experiment at this point, but hopefully it could turn into a real proposal! |
2d153a6 to
515c9c1
Compare
515c9c1 to
2bf7561
Compare
|
Let's close in favor of #17950 which is more up to date. It looks like it follows the same approach. |
Description
Explores #11491.
This is an experiment to add gutenberg-mobile build and tools to gutenberg.
New packages added:
@wordpress/react-native-gutenberg-editor@wordpress/react-native-gutenberg-bridge@wordpress/react-native-aztec@wordpress/react-native-e2e-testsUsual
yarncommands ran fromgutenberg-mobileare now accessible fromgutenbergusingnpm run native ....For instance:
yarn start=>npm run native startbundlehowever, has been replaced withbuildto follow gutenberg naming conventionsyarn bundle:android=>npm run native buildSome commands that are out of date have been removed (makepot...)
This is still a work in progress. Currently, the demo app does not work as
masteris broken on native (see #17228 for a fix), native tests are failing withTypeError: r.editor is not a functioninpackages/edit-post/src/test/editor.native.js, and many things remain untested.How has this been tested?
TBD.
npm installnpm run native start:resetandnpm run native androidnpm run build...
Types of changes
Add new native packages, for native build, unifying the 2 repositories
Checklist:
package-lock.jsonare OKgutenberg-mobiledevelop branchgradle-wrapper.jarcommitted to the repo though and we might want to fix that later?)