Editor: Don't edit the post when autosaving.#17420
Merged
Conversation
mcsf
reviewed
Sep 12, 2019
| previousRecord.type, | ||
| previousRecord.id | ||
| ) ), | ||
| ...edits, |
Contributor
There was a problem hiding this comment.
Could you explain this concatenation?
Contributor
Author
There was a problem hiding this comment.
We still want autosaves to have the latest content. This makes sure of that without editing the entity.
mcsf
reviewed
Sep 13, 2019
Contributor
mcsf
left a comment
There was a problem hiding this comment.
This makes sense, but there's still several concepts to track in just one action creator. We need tests for this sort of regression, could you work on it?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR stops the editor from clearing redo levels when autosaving.
How has this been tested?
It was verified that autosaves no longer clear the redo stack.
Types of Changes
Bug Fix: Stop autosaves from clearing the redo stack.
Checklist: