Fix core/column not having templateLock inherited from posttype template#17301
Closed
oxyc wants to merge 3 commits intoWordPress:trunkfrom
Closed
Fix core/column not having templateLock inherited from posttype template#17301oxyc wants to merge 3 commits intoWordPress:trunkfrom
oxyc wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
I left some possible improvements in the comments. Personally I feel this is a positive change. Thank you for your contribution 👍
8875bd7 to
92f9779
Compare
92f9779 to
db6e3c5
Compare
db6e3c5 to
8697b04
Compare
6 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #17262 although this only fixes the inconsistency, not the issues expected behavior which I personally disagree with.
Basically
core/columnsets thetemplateLocktofalseto override the parentcore/columnsblocksall. This however doesn't take into account the post type templateLock.This PR inherits the templateLock from the parent of the parent
core/columnsblock.How has this been tested?
Added a locked post type template with a column block and verified it's not possible to add child blocks. On an unlocked post type template, it is still possible to add.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: