Merged
Conversation
youknowriad
reviewed
Jul 4, 2017
| "lodash": "^4.17.4", | ||
| "moment": "^2.18.1", | ||
| "moment-timezone": "^0.5.13", | ||
| "pegjs": "0.10.0", |
Contributor
There was a problem hiding this comment.
Do we really need it in dependencies or should it be moved to devDependencies? I guess it's used only for generating parsers in dev, am I wrong?
Member
Author
There was a problem hiding this comment.
Right. I misread that part in #1152. It only just a dev dependency before.
4 tasks
Member
|
Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1152 duplicated the pegjs reference in
package.jsonand also addedphpegjsas a regular dependency instead of a dev dependency.This PR attempts to fix that.