Conversation
… available for parse-time validation.
6ae631d to
1ca56ca
Compare
5 tasks
draganescu
approved these changes
Aug 5, 2019
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Works as described, code is good :)
Contributor
Author
|
Tests are failing a lot though. |
Contributor
Author
|
Closing this as the issue was resolved by making blocks pure functions of their attributes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16429
Description
Validation runs during parsing when
EditorProvideris constructed, but needs to use settings, e.g. colors, which are first set whenBlockEditorProvideris mounted.Either moving validation out of the parsing step or moving
EditorProviderconstructor setup side effects intocomponentDidMountwould fix this (becausecomponentDidMountruns children => parent).We should do the latter anyways, in preparation for the next version of React, so this PR takes that route.
How has this been tested?
It was verified that a page with a pullquote block using the
primarycolor from settings is no longer failing validation.Types of Changes
Bug Fix: Setup editor and block-editor in the right order so that settings like colors are available during parse-time block validation.
Checklist: