Merging blocks: clone blocks to safely insert selection tracking character#16419
Merged
Merging blocks: clone blocks to safely insert selection tracking character#16419
Conversation
koke
approved these changes
Jul 5, 2019
Contributor
koke
left a comment
There was a problem hiding this comment.
I wasn't able to reproduce the original description on mobile or the crash in wordpress-mobile/WordPress-iOS#11950, but the approach of cloning the blocks seems like it could help
Member
Author
|
Thanks @koke. This seems generally a good improvement and hopefully fixes the issue. Let me know if the Sentry reports stop or not. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Might fix wordpress-mobile/WordPress-iOS#11950?
How has this been tested?
Insert a list and a heading. Try to merge the heading with list. Select something else. Ensure that no space is added before the heading text. In master, some whitespace is added.
Screenshots
Types of changes
Checklist: