Skip to content

Update iframeTitle hardcoded text w/ sprintf for i18n #1612#1635

Merged
youknowriad merged 4 commits intoWordPress:masterfrom
DevinWalker:update/iframe-i18n
Jul 3, 2017
Merged

Update iframeTitle hardcoded text w/ sprintf for i18n #1612#1635
youknowriad merged 4 commits intoWordPress:masterfrom
DevinWalker:update/iframe-i18n

Conversation

@DevinWalker
Copy link
Copy Markdown
Contributor

PR Overview

Implemented sprintf to make hardcoded string translatable.

Resolves #1612

@DevinWalker DevinWalker changed the title sprintf for i18n #1612 Update iframeTitle hardcoded content w/ sprintf for i18n #1612 Jul 1, 2017
@DevinWalker DevinWalker changed the title Update iframeTitle hardcoded content w/ sprintf for i18n #1612 Update iframeTitle hardcoded text w/ sprintf for i18n #1612 Jul 1, 2017
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants