Configure Babel to target your current version of Node with Jest#16259
Merged
Conversation
1 task
aduth
reviewed
Jun 25, 2019
caed531 to
1330a79
Compare
1330a79 to
f2b9ca1
Compare
youknowriad
approved these changes
Jul 29, 2019
youknowriad
left a comment
Contributor
There was a problem hiding this comment.
The changes seem reasonable to me. We'd have to try an update the setup in Core later to test this properly.
Member
Author
Yes, I can take care of it as soon as this change is published to npm. I also want to set up a very basic e2e test in https://github.com/WordPress/gutenberg-examples which would help to ensure this works as expected whenever we publish a new version to npm. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It aims to fix the issue raised by @youknowriad in WordPress/wordpress-develop#69 (comment).
Fixes #16262.
This PR adds the missing
babel-jestdependency and tries to update Babel config to remove the need forcore-jsbut it seems like it's not working as intended.How has this been tested?
Screenshots
Types of changes
Checklist: