Skip to content

Add native component HTMLTextInput#16226

Merged
Tug merged 3 commits intomasterfrom
rnmobile/add/html-text-input-component
Jun 21, 2019
Merged

Add native component HTMLTextInput#16226
Tug merged 3 commits intomasterfrom
rnmobile/add/html-text-input-component

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Jun 19, 2019 •
edited
Loading

Description

This is step 7 of wordpress-mobile/gutenberg-mobile#958
It ports the HTMLTextInput component from gutenberg-mobile to gutenberg. For reference this component is a simple HTML text editor for mobile native.

How has this been tested?

Tested with GB mobile PR wordpress-mobile/gutenberg-mobile#1162

Types of changes

Adding native only component: an html editor

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 19, 2019
@Tug Tug added this to the Future milestone Jun 19, 2019
@Tug Tug self-assigned this Jun 19, 2019
@Tug Tug force-pushed the rnmobile/add/html-text-input-component branch from aee520e to d1bd3b5 Compare June 20, 2019 07:36
@koke koke mentioned this pull request Jun 20, 2019
Closed
10 tasks
@Tug Tug marked this pull request as ready for review June 20, 2019 09:11
@Tug Tug requested review from SergioEstevao, etoledom and hypest June 21, 2019 06:49
etoledom
etoledom approved these changes Jun 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via wordpress-mobile/gutenberg-mobile#1162 (review)

@Tug Tug mentioned this pull request Jun 21, 2019
Merged
@Tug
Copy link
Copy Markdown
Contributor Author

Tug commented Jun 21, 2019

Thanks for the review @etoledom 🎉

@Tug Tug merged commit 705d744 into master Jun 21, 2019
@Tug Tug deleted the rnmobile/add/html-text-input-component branch June 21, 2019 09:04
@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.0 Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etoledom etoledom etoledom approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@hypest hypest Awaiting requested review from hypest

Assignees

@Tug Tug

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

Gutenberg 6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Tug @etoledom @youknowriad