Skip to content

Add native support for BlockListBlock (Ported from Gutenberg mobile)#16223

Merged
Tug merged 2 commits intomasterfrom
rnmobile/add/block-list-block-component
Jun 20, 2019
Merged

Add native support for BlockListBlock (Ported from Gutenberg mobile)#16223
Tug merged 2 commits intomasterfrom
rnmobile/add/block-list-block-component

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Jun 19, 2019

Description

This is step 6 of wordpress-mobile/gutenberg-mobile#958
This PR ports the gutenberg-mobile BlockHolder to gutenberg as the BlockListBlock component inside @wordpress/block-editor.
This is needed to implement Inner blocks for mobile native. You can follow the progress of the port here wordpress-mobile/gutenberg-mobile#958

How has this been tested?

GB Mobile PR wordpress-mobile/gutenberg-mobile#1155

Types of changes

Adds native support for a block editor component

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug added [Status] In Progress Tracking issues with work in progress Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jun 19, 2019
@Tug Tug added this to the Future milestone Jun 19, 2019
@Tug Tug self-assigned this Jun 19, 2019
@Tug Tug requested review from SergioEstevao, etoledom and koke June 19, 2019 14:39
@Tug Tug removed the [Status] In Progress Tracking issues with work in progress label Jun 19, 2019
@Tug Tug requested review from hypest and removed request for koke June 19, 2019 14:40
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@Tug Tug merged commit e60fffb into master Jun 20, 2019
@Tug Tug deleted the rnmobile/add/block-list-block-component branch June 20, 2019 07:11
@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.0 Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants