Conversation
…d from gutenberg mobile)
10 tasks
etoledom
approved these changes
Jun 18, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looks good!
Tested via wordpress-mobile/gutenberg-mobile#1149 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is step 5 of wordpress-mobile/gutenberg-mobile#958
This PR ports the gutenberg-mobile BlockToolbar to gutenberg in the @wordpress/block-editor package.
This is needed to implement Inner blocks for mobile native. You can follow the progress of the port here wordpress-mobile/gutenberg-mobile#958
This PR is a simple port, it has very limited changes compared with the original BlockToolbar in gutenberg-mobile
How has this been tested?
wordpress-mobile/gutenberg-mobile#1149
Types of changes
Adds native support for a block editor component
Checklist: