Skip to content

Correct text zoom issue in the Content Structure popover#15984

Merged
kjellr merged 1 commit into
masterfrom
fix/text-zoom-issue-for-content-structure-popup
Jun 24, 2019
Merged

Correct text zoom issue in the Content Structure popover#15984
kjellr merged 1 commit into
masterfrom
fix/text-zoom-issue-for-content-structure-popup

Conversation

@kjellr

@kjellr kjellr commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

Fixes #15357.

As noted in the issue, text in the Content Structure popover currently overlaps when using the browser's text zoom feature. This PR switches the fixed percentage width to use the somewhat more flexibleflex-basis instead. It also adds a tiny bit of spacing in between each item.


Before

Viewed at 100%
Screen Shot 2019-06-04 at 2 51 11 PM

Viewed at 200%
Screen Shot 2019-06-04 at 2 50 57 PM


After

Viewed at 100% (No changes)

Screen Shot 2019-06-04 at 2 49 43 PM

Viewed at 200%

Screen Shot 2019-06-04 at 2 50 20 PM

@kjellr kjellr added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Document Outline An option that outlines content based on a title and headings used in the post/page Needs Accessibility Feedback Need input from accessibility [a11y] Zooming labels Jun 4, 2019
@kjellr kjellr self-assigned this Jun 4, 2019
@kjellr kjellr requested a review from afercia June 4, 2019 18:57

@afercia afercia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjellr thanks! Screenshot including some the first heading in the content structure popover, from Firefox with zoom > text only at very high level:

Screenshot 2019-06-13 at 17 17 25

Looks good to me: the text doesn't overlap.

Ideally, the popover width should be able to adjust a bit depending on the available space. Something like a "range" between a min and max width maybe. Not sure if that would impact the calculation of the popover position which is done via JavaScript. If possible, I'd encourage some exploration in that direction 🙂

The build fails, not sure why.

@afercia afercia removed the Needs Accessibility Feedback Need input from accessibility label Jun 13, 2019

@jorgefilipecosta jorgefilipecosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is passing, and the change looks good to me 👍 I guess we can merge this solution but I agree it would be good to explore a dynamic popup width in other PR/issue.

@kjellr

kjellr commented Jun 24, 2019

Copy link
Copy Markdown
Contributor Author

Thank you both!

@kjellr kjellr merged commit c3f65fb into master Jun 24, 2019
@kjellr kjellr deleted the fix/text-zoom-issue-for-content-structure-popup branch June 24, 2019 16:15
@kjellr kjellr added this to the Gutenberg 6.0 milestone Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Document Outline An option that outlines content based on a title and headings used in the post/page [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content overlaps at 200% text enlarge

4 participants