Fix link viewer URL to navigate to resource#1584
Merged
Conversation
youknowriad
reviewed
Jun 29, 2017
blocks/editable/format-toolbar.js
Outdated
| <a | ||
| className="editable-format-toolbar__link-value" | ||
| href={ this.state.linkValue } | ||
| target="_black" |
Member
Author
There was a problem hiding this comment.
Huh. :D Shows how drugged I was yesterday.
Member
Author
There was a problem hiding this comment.
Interestingly Chrome still opens it in a new tab.
ed651be to
e8a2b25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It currently prompts to edit the link instead of opening it in a new window.