Update node-sass#15613
Merged
Merged
Conversation
Member
Author
|
Opened an accompanying ticket for Core. |
Member
|
This was discussed during today's #core-js chat (link requires registration): https://wordpress.slack.com/archives/C5UNMSU4R/p1557843578353500 Noted there that technically the project doesn't support Node 12.x yet. That being said, this seems like a reasonable and non-conflicting change, with the added benefit of improved future compatibility.
https://github.com/WordPress/gutenberg/blob/master/docs/contributors/getting-started.md
|
Member
aduth
approved these changes
May 15, 2019
aduth
left a comment
Member
There was a problem hiding this comment.
Looks good 👍 Tested successfully both in Node 10.15.3 (active LTS) and Node 12.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
npm installcurrently fails when running the latest version of Node (12.2.0 with NPM 6.9.0).The repo currently requires ~4.11.0 of
node-sass, but only4.12+supports Node 12.2.0.