A11y: update icon for heading block#15462
Conversation
| title: __( 'Heading' ), | ||
| description: __( 'Introduce new sections and organize content to help visitors (and search engines) understand the structure of your content.' ), | ||
| icon, | ||
| icon: 'heading', |
There was a problem hiding this comment.
I'm pretty sure this was done on purpose. Would be good to check the original reasons for using "T". I think it's related to i18n
There was a problem hiding this comment.
See #15340 (comment) and #15340 (comment). From what I understood in #15340 @mapk OK'd the change to H over T.
There was a problem hiding this comment.
I do understand the "H" is not a i18n standard for Headings, but it does match the H2, H3, and H4 heading sizes that are surfaced in the block toolbar. So there's some consistency there. Other apps like Dropbox Paper also use "H" for the heading level.
marekhrabe
left a comment
There was a problem hiding this comment.
It looks like we have a consensus about using the H icon and code-wise, nothing else blocks this PR.
|
Yes, |
LGTM!
Description
Fixes #15340
Issue description
The "Block Type" menu, and block editor type button, use icons for
each block, and in most cases these are good representations of the
block. However the "Heading" block type uses the letter "T", which
is potentially confusing, since "Heading" doesn't start with "T".
Remediation Guidance
Use the letter "H" as the icon for the Heading block type. This also
matches the other H icons used for setting the level (H2, H3, etc.).
Screenshots
Types of changes
headingChecklist: