Framework: Remove packages build from build, dev scripts#15226
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #15219
Related: #14560
This pull request seeks to update the Gutenberg-specific Webpack configuration to avoid running Babel as part of the Webpack build. As described at #15219 (comment), the files processed by Webpack are already transpiled by Babel as a step immediately prior. Including
babel-loaderis therefore redundant, wasted effort.With this change, I'd measured approximately a 57% decrease in the time it takes to run
npx wp-scripts build(~16.7s to 7.1s, measured usingtime).Testing Instructions:
git clean -fdx(Warning: This will forcefully remove any uncommitted files)npm run buildbuild/*/*.jsand inpackages/*/build/*.jsare transpiled as expected by Babel (e.g. no ES2015 or JSX)