Try tweaking the specificity of the custom color syntax#15167
Merged
Try tweaking the specificity of the custom color syntax#15167
Conversation
This fixes #12986 and is based on the conversation there. Instead of doubling the selectors to increase specificity, we are supplying the element as well.
added 2 commits
April 29, 2019 09:43
Contributor
Author
|
Thanks for the review! Addressed the points. |
jorgefilipecosta
approved these changes
May 3, 2019
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
LGTM 👍 The specificity is not changed so users should not notice any difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #12986 and is based on the conversation there.
Instead of doubling the selectors to increase specificity, we are supplying the element as well.