Skip to content

Suppress the List block on Android#15100

Closed
hypest wants to merge 2 commits intomasterfrom
gbmobile/disable-list-block-on-android
Closed

Suppress the List block on Android#15100
hypest wants to merge 2 commits intomasterfrom
gbmobile/disable-list-block-on-android

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Apr 22, 2019

Description

This PR is open to track the gbmobile/disable-list-block-on-android branch, which disables the List block for Android only. We'll use this branch for the v1.3 release of gutenberg-mobile but we may choose not to merge it to master since we'll want to continue working/fixing the list block support on Android.

This PR is based on 0883192, which it the commit last used in the v1.3 release process for gutenberg-mobile.

How has this been tested?

Using this gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#906

Types of changes

Disable the registration of the List block but only for Android

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Apr 22, 2019

Tagged commit a8073b4 with rnmobile/release-v1.3.0 so GitHub/git keeps the reference to it and will now close this PR. We don't need to merge this as the goal is to keep the list block enabled on gutenberg-mobile develop anyway.

@hypest hypest closed this Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants