Paste: apply active formats when pasting inline#14815
Merged
Conversation
Member
|
Is this still valid? |
Member
Author
|
Yes |
Contributor
|
I wanted to review this but it looks like it needs a rebase since the code changed a lot. |
886b180 to
74ca7fb
Compare
74ca7fb to
72cb5ad
Compare
Contributor
|
Looks like |
This was referenced Dec 17, 2019
Contributor
|
PR is up to fix the regression: #19190 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11571. When pasting inline, we should merge the formats of the pasted record with the active formats, not just insert the value without the active formats. When you paste something inline in a rich text area, you'd expect it to preserve any active formats.
How has this been tested?
See #11571.
Screenshots
Types of changes
Bug fix.
Checklist: