Block library: Introduce block.json metadata for all client side blocks#14770
Merged
Block library: Introduce block.json metadata for all client side blocks#14770
Conversation
9fe927f to
73424ca
Compare
73424ca to
565618e
Compare
youknowriad
reviewed
Apr 3, 2019
youknowriad
reviewed
Apr 3, 2019
packages/e2e-tests/fixtures/blocks/core__image__center-caption.json
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Apr 3, 2019
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
I like this iterative approach. I left a few questions. I also saw that you didn't move the file block attributes because of the i18n issue, we should try the solution discussed in #core-js here.
Member
Author
Yes, Tabel and File blocks have some challenges which I plan to resolve later this week. Update: File block is being addressed in #14862. Table block is being addressed in #14863. |
7616373 to
45723df
Compare
45723df to
3de1a78
Compare
This was referenced Apr 15, 2019
Closed
Closed
5 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up for #14551 which introduced a way to inline
block.jsonmetadata.Scope covered by this PR:
block.jsonfiles for the following fields:namecategoryattributesThere were 2 exceptions where I couldn't easily move
attributesto JSON file:defaultvalue for an attribute (https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/file/index.js#L64-L69)I opened separate PRs for them: #14862 and #14863.
How has this been tested?
npm run testnpm run devand ensure all blocks work as before.