Skip to content

Native support for BlockList#14662

Closed
Tug wants to merge 6 commits intomasterfrom
rnmobile/add/block-list
Closed

Native support for BlockList#14662
Tug wants to merge 6 commits intomasterfrom
rnmobile/add/block-list

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Mar 27, 2019 •
edited
Loading

Description

This PR adds native support for BlockList and various related components. It basically ports our block management code from gutenberg-mobile to gutenberg.
This is a first step towards having inner block support in native.

Here is the list of components which now have native/rnmobile support:

It also port some mobile specific components and add them to packages/components/src/mobile/:

How has this been tested?

More details of the changes and testing instructions are given on the gubenberg-mobile PR:
wordpress-mobile/gutenberg-mobile#789

@Tug Tug added [Status] In Progress Tracking issues with work in progress Mobile Web Viewport sizes for mobile and tablet devices Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Mar 27, 2019
@Tug Tug self-assigned this Mar 27, 2019
@Tug Tug mentioned this pull request Mar 27, 2019
Closed
@Tug Tug removed the [Status] In Progress Tracking issues with work in progress label Mar 28, 2019
gziolo
gziolo reviewed Mar 29, 2019
View reviewed changes
packages/block-library/src/index.native.js Outdated
import * as paragraph from './paragraph';
import * as image from './image';
import * as nextpage from './nextpage';
import * as UnsupportedBlock from './mobile/unsupported-block';
Copy link
Copy Markdown
Member

@gziolo gziolo Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether it should be moved to gutenberg-mobile project. It's something that is specific only to the mobile project so doesn't quite makes sense here as it doesn't have web alternative.

Copy link
Copy Markdown
Contributor Author

@Tug Tug Apr 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#14577 's goal is to actually rename unsupported-block to missing, so we are in sync with the web part. I agree it might look confusing to have a rnmobile only block in the core block library but it isn't exposed to the web version and I think it's only temporary. We need those dependencies in gutenberg as they are required by other part of the code, see https://github.com/WordPress/gutenberg/pull/14662/files#diff-61ba183209a287f5b2da76defa6e20fbR7 and https://github.com/WordPress/gutenberg/pull/14662/files#diff-8aa4726165b0e0cdb260abe61e3329ceR10 for instance.

Moreover, our goal is to actually move most of the gutenberg-mobile JS code to the gutenberg project, so keeping "unrelated to the web" code out of the gutenberg repo isn't compatible with this approach

Copy link
Copy Markdown
Member

@gziolo gziolo Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#14577 's goal is to actually rename unsupported-block to missing, so we are in sync with the web part.

This would be awesome and exactly addresses my point.

@Tug Tug force-pushed the rnmobile/add/block-list branch from 5d3fcac to fed27ef Compare April 5, 2019 15:04
@Tug
Copy link
Copy Markdown
Contributor Author

Tug commented Apr 5, 2019

Rebased ontop of master and brought latest changes from gutenberg-mobile.
Tests are currently failing but this is due to master currently failing

@Tug Tug force-pushed the rnmobile/add/block-list branch 2 times, most recently from 76661f1 to a595f33 Compare April 12, 2019 13:36
This was referenced Apr 13, 2019
Closed
Closed
@Tug Tug force-pushed the rnmobile/add/block-list branch 2 times, most recently from e350f06 to 3d29632 Compare April 17, 2019 11:44
@Tug Tug force-pushed the rnmobile/add/block-list branch from 3d29632 to 61128c0 Compare April 18, 2019 08:53
@Tug Tug mentioned this pull request May 21, 2019
Closed
8 tasks
@koke koke mentioned this pull request May 22, 2019
Closed
10 tasks
@Tug
Copy link
Copy Markdown
Contributor Author

Tug commented Jun 6, 2019

Closing this PR. Progress of this is now being monitored on wordpress-mobile/gutenberg-mobile#958

@Tug Tug closed this Jun 6, 2019
@Tug Tug deleted the rnmobile/add/block-list branch June 6, 2019 20:12
@gziolo gziolo removed the Mobile Web Viewport sizes for mobile and tablet devices label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@noisysocks noisysocks Awaiting requested review from noisysocks

@notnownikki notnownikki Awaiting requested review from notnownikki

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@Tug Tug

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tug @gziolo