Skip to content

Mobile: Fix links ui on landscape iOS v2#14240

Merged
etoledom merged 2 commits intornmobile/developfrom
rnmobile/links-ui-landscape-ios-v2
Mar 5, 2019
Merged

Mobile: Fix links ui on landscape iOS v2#14240
etoledom merged 2 commits intornmobile/developfrom
rnmobile/links-ui-landscape-ios-v2

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Mar 5, 2019

gutenberg-mobile reference: wordpress-mobile/gutenberg-mobile#701

Description

This PR fixes an issue on KeyboardAvoidingView, that was adding extra bottom padding on specific circumstances:

  • iOS.
  • Landscape.
  • Keyboard already present.
  • BottomSheet presenting with a TextInput on Autofocus.

With some debugging I noticed a problem on the way the extra padding is calculated, so I made a simplified version of the component that will work well on the BottomSheet.

links-ui-landscape

Note: The BottomSheet is not scrollable (yet).

To test:

  • Check that the Links UI presents properly on Landscape mode.
  • If possible, test WPiOS and Android.
  • Android should work exactly as before.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants