Skip to content

rich-text: set up autogenerated API docs#14220

Merged
oandregal merged 24 commits intomasterfrom
update/api-docs-rich-text
Mar 7, 2019
Merged

rich-text: set up autogenerated API docs#14220
oandregal merged 24 commits intomasterfrom
update/api-docs-rich-text

Conversation

@oandregal
Copy link
Copy Markdown
Member

@oandregal oandregal commented Mar 4, 2019

Related to #14227

This PR sets up auto-generated API docs for the rich-text package through the npm run docs:build command and updates its README file.

Notable modifications

  • Fixed optional parameters. Should be {type} [param], not {?type} param.
  • Fixed returns when type can be undefined. Should be {type|undefined}, not {?type}.
  • New symbols added that were undocumented:
    • insertObject
    • unregisterFormatType
  • Symbols that were documented and are removed in this PR: apply.
  • Symbols that stay undocumented:
    • changeListType
    • charAt
    • getSelectionEnd
    • getSelectionStart
    • indentListItems
    • insertLineBreak
    • insertLineSeparator
    • isEmptyLine
    • LINE_SEPARATOR
    • outdentListItems
    • unstableToDom

Test instructions

  • Delete or modify the contents at packages/rich-text/README.md within the start <!-- START TOKEN(Autogenerated API docs) --> and end <!-- END TOKEN(Autogenerated API docs) --> tokens.
  • Execute npm run docs:build and verify they are re-created.
  • Review that the API docs match the JSDoc of the exported symbols.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Package] Rich text /packages/rich-text [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants