Skip to content

Add repository.directory linting rule (fixes #13947)#14200

Merged
gziolo merged 8 commits intoWordPress:masterfrom
greatislander:add/repository-directory-lint
Mar 4, 2019
Merged

Add repository.directory linting rule (fixes #13947)#14200
gziolo merged 8 commits intoWordPress:masterfrom
greatislander:add/repository-directory-lint

Conversation

@greatislander
Copy link
Copy Markdown
Contributor

@greatislander greatislander commented Mar 1, 2019

Description

The bundled npm-package-json-lint dependency has been updated from requiring ^3.3.1 to requiring ^3.6.0, adding a rule which enforces the presence of the repository.directory field. This resolves #13947.

How has this been tested?

Ran npm run lint-pkg-json to confirm that all packages passed; manually triggered failure by removing repository.directory field from packages/wordcount.

Types of changes

New feature (non-breaking change which adds functionality)

Additional notes

Ran into issues upgrading the npm-package-json-lint dependency. @aduth identified recent changes (#14156, #14192) which were possibly related and proposed a solution (see Slack conversation). His solution resolved the issue, which is why the package-lock.json diff is larger than would be expected.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Packages Related to npm packages [Type] Code Quality Issues or PRs that relate to code quality [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scripts: Enforce repository.directory in package.json lint script

4 participants