Add repository.directory linting rule (fixes #13947)#14200
Merged
gziolo merged 8 commits intoWordPress:masterfrom Mar 4, 2019
Merged
Add repository.directory linting rule (fixes #13947)#14200gziolo merged 8 commits intoWordPress:masterfrom
gziolo merged 8 commits intoWordPress:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bundled
npm-package-json-lintdependency has been updated from requiring^3.3.1to requiring^3.6.0, adding a rule which enforces the presence of therepository.directoryfield. This resolves #13947.How has this been tested?
Ran
npm run lint-pkg-jsonto confirm that all packages passed; manually triggered failure by removingrepository.directoryfield frompackages/wordcount.Types of changes
New feature (non-breaking change which adds functionality)
Additional notes
Ran into issues upgrading the
npm-package-json-lintdependency. @aduth identified recent changes (#14156, #14192) which were possibly related and proposed a solution (see Slack conversation). His solution resolved the issue, which is why thepackage-lock.jsondiff is larger than would be expected.Checklist: