Plugin: Remove PHP functions slated for removal in 5.2#14090
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to remove functions deprecated as part of the Gutenberg 5.0 release, slated for removal with the upcoming version 5.2.
Implementation notes:
As noted at #14012 (comment), a few functions were wrongly labeled as deprecated with 5.0 when in fact they were deprecated in the 5.1 release. Those have not been removed here, and their version deprecations have been updated to align to the deprecations document, where they are correctly noted as being removed in the following 5.3 release:
https://github.com/WordPress/gutenberg/blob/master/docs/designers-developers/developers/backward-compatibility/deprecations.md
The script
bin/get-server-blocks.phpstill included a reference togutenberg_prepare_blocks_for_js. The deprecated warning was not logged because the file disables error reporting. This has been updated accordingly here. Separately, we should consider:Related: #13583 (comment)
Testing instructions:
Verify there are no regressions in the load and operation of the error.
Verify there are no warnings or errors logged (by PHP) when loading the editor (with and without meta boxes) or the reusable blocks list screen.
Ensure there are no remaining occurrences of deprecated functions to be removed in the 5.2 release.