Skip to content

Cleanup URL Popover stylesheet#14015

Merged
kjellr merged 1 commit intomasterfrom
update/url-popover-sass-cleanup
Feb 21, 2019
Merged

Cleanup URL Popover stylesheet#14015
kjellr merged 1 commit intomasterfrom
update/url-popover-sass-cleanup

Conversation

@kjellr
Copy link
Copy Markdown
Contributor

@kjellr kjellr commented Feb 21, 2019

As noted in #13973 (comment), the URL Popover stylesheet uses a relatively non-standard SCSS method of nesting some classnames. For instance:

.editor-url-popover { 
    &__settings-toggle { 
        ...
    } 
}

... instead of:

.editor-url-popover__settings-toggle { 
    ...
}

This is different from the conventions used elsewhere in Gutenberg, and is a bit more difficult to follow for that reason.

This commit un-nests those styles, and should have no effect on the compiled CSS.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants