Upgrade Jest to version 24 (breaking changes)#13922
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following changes were applied in this PR:
jestdependency has been updated from requiring^23.6.0to requiring^24.1.0(see Braking Changes.jest-puppeteerdependency has been updated from requiring3.2.1to requiring^4.0.0.The bundled- it looks like such upgrade on its own breaks our e2e tests ...puppeteerdependency has been updated from requiring1.6.1to requiring^1.12.2.jest-enzymedependency has been removed completely (it doesn't work with Jest 24 and we rather sunset support for Enzyme one day than continue to suffer keeping it up to date).enzymedependency has been updated from requiring^3.7.0to requiring^3.9.0.babel-coredependency acting as Babel 7 bridge (no longer needed by Jest 24).The biggest internal change caused by Jest upgrade was the need to replace usage of
setupTestFrameworkScriptFilewithsetupFilesAfterEnv. Otherwise, as noted above, I had to removejest-enzymedependency and therefore update a few assertions which were using custom matchers.There are 3 packages which were also updated but they weren't published to npm so far so I didn't update the corresponding changelog files:
jest-puppeteer-axee2e-test-utilse2e-testsHow has this been tested?
npm testnpm run test-e2eChecklist: