Skip to content

RichText: React tree instead of DOM tree#13838

Closed
ellatrix wants to merge 1 commit intomasterfrom
try/react-tree-2
Closed

RichText: React tree instead of DOM tree#13838
ellatrix wants to merge 1 commit intomasterfrom
try/react-tree-2

Conversation

@ellatrix
Copy link
Copy Markdown
Member

@ellatrix ellatrix commented Feb 12, 2019

Description

WIP!

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@gziolo gziolo added this to the 5.2 (Gutenberg) milestone Feb 13, 2019
@gziolo gziolo added [Status] In Progress Tracking issues with work in progress [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement. labels Feb 13, 2019
@gziolo gziolo removed this from the 5.2 (Gutenberg) milestone Feb 13, 2019
@ellatrix ellatrix mentioned this pull request Feb 13, 2019
Merged
5 tasks
@ellatrix
Copy link
Copy Markdown
Member Author

ellatrix commented Mar 20, 2019

I'm running into issues when attempting this again. Most of the errors I get seem to be related to the fact that the DOM goes out of sync with React's virtual DOM, leaving React unable to reconcile for some reason.

react-dom.min.fa9ca8c8.js:117 DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

I'm going to close this PR for now, until I think of a way to do it better.

@ellatrix ellatrix closed this Mar 20, 2019
@ellatrix ellatrix deleted the try/react-tree-2 branch March 20, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth Awaiting requested review from aduth

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

No one assigned

Labels

[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ellatrix @gziolo