Plugin: Remove vendor script registration#13573
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to remove Gutenberg's own registration of vendor dependencies, instead relying on those versions provided by core. The associated utility functions have not been deprecated, with some expectation that Gutenberg may again need to re-introduce newer dependency versions at some point in the future (e.g. #11161). I'm open to considering this as YAGNI though, with a proper deprecation under the assumption that it could be restored at a point in the future if/when it's needed.
Inline scripts for vendor dependencies have also been removed, since these would duplicate those already provided by core.
Testing instructions:
Verify that there are no regressions in the load of Gutenberg, that via the network tab you observe vendor dependencies loaded from the core installation, and that the inline scripts removed with these changes are still present in the markup of the editor screen even after their removal from the plugin.