Framework: Use imports for WordPress modules instead of the wp global#1332
Framework: Use imports for WordPress modules instead of the wp global#1332youknowriad merged 2 commits intomasterfrom
wp global#1332Conversation
|
Love it. Do you think we can remove the wp global from eslint too, for better testing? |
|
If we need it anywhere else for external stuff, we can force |
|
@iseulde Not against it, but maybe there're too much |
|
Hm, ran it and it passes? |
|
Aha forgot it inherits from other config. Will remove commit |
369681d to
a9ad2f0
Compare
|
In that case, can we change that with Webpack? It seems strange to still have both after this PR. |
|
Mostly asking because I'm not sure how we'll prevent it from being introduced again unknowingly. |
I'm trying but failing to define these modules in webpack. It seems to accept |
|
Oh, this has been attempted before: #742. |
|
Yeah, |
|
Yeah, I'm thinking we'd need to add a namespace to resolve this Anyway, I'm keen to merge this as a first step and see how to solve the external wp modules issue. |
blocks/editable/index.js
Outdated
There was a problem hiding this comment.
Capitalization: We should probably prefer TinyMCE, createTinyMCEElement
a9ad2f0 to
ce6bde0
Compare
part of #1205
I would appreciate a quick review for this to avoid many conflicts :)