Skip to content

Placeholder: fix missing margin on block icons that are not dashicons#11947

Merged
mtias merged 1 commit intomasterfrom
fix/block-icon-in-placeholders
Nov 16, 2018
Merged

Placeholder: fix missing margin on block icons that are not dashicons#11947
mtias merged 1 commit intomasterfrom
fix/block-icon-in-placeholders

Conversation

@mtias
Copy link
Copy Markdown
Member

@mtias mtias commented Nov 15, 2018

The placeholder component is only adding margin for block icons that are dashicons.

Before:
image

After
image

@mtias mtias added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels Nov 15, 2018
@mtias mtias added this to the 4.5 milestone Nov 15, 2018
@gziolo gziolo requested a review from jasmussen November 16, 2018 13:37
Copy link
Copy Markdown
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Ship it.

@mtias mtias merged commit 9591c90 into master Nov 16, 2018
@mtias mtias deleted the fix/block-icon-in-placeholders branch November 16, 2018 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants