Stop propagating to DOM elements the focusOnMount prop from NavigableToolbar components#11804
Merged
Stop propagating to DOM elements the focusOnMount prop from NavigableToolbar components#11804
focusOnMount prop from NavigableToolbar components#11804Conversation
…nt' into fix/navigable-toolbar-focusonmount
jorgefilipecosta
approved these changes
Nov 13, 2018
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
LGTM 👍 Thank you for catching and fixing this bug.
I checked on React dev tools that the prop is not passed down.
I do not see the warning in the console; I'm trying to check why it does not appear in my environment.
Contributor
Author
|
@jorgefilipecosta yeah, I don't see the warning when running locally Gutenberg. I think that the build process is suppressing the warning messages. I can see it when using the package in another project like Calypso (Automattic/wp-calypso#28427 (comment)). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
focusOnMountfrom the props transferred toNavigableMenuwhen rendering aNavigableToolbarcomponent.Fixes #11769.
How has this been tested?
Locally by checking in the React devtools that the
focusOnMountprop is not passed down to the children.Screenshots
Before
After
Types of changes
Bug fix
Checklist: