Components: Restore click-to-close behavior of Dropdown toggle#11633
Merged
Components: Restore click-to-close behavior of Dropdown toggle#11633
Conversation
Previously assumed the selector would throw if not found, but in-fact returns `null`. See: https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pageselector
oandregal
approved these changes
Nov 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #11579
Regression introduced in #11253
Effectively reverts 58725c4
This pull request seeks to resolve a regression where clicking a Dropdown toggle button while the Dropdown's Popover is already opened results in the Popover remaining opened.
Testing instructions:
Verify that clicking a Dropdown toggle button while the Popover is visible results in the popover being hidden.
Ensure end-to-end tests pass: