Fix: Translator comments are not included for quote and pullquote placeholders#11514
Merged
jorgefilipecosta merged 1 commit intomasterfrom Nov 6, 2018
Conversation
…ile for quote and pullquote placeholders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11494
The translator comments for quote and pullquote placeholders were not included in the "/languages/gutenberg-translations.php" file.
This PR just applies very simple changes to the source without any functional meaning to make sure the translator comments appear.
How has this been tested?
Generate the /languages/gutenberg-translations.php file e.g: by executing ./bin/build-plugin-zip.sh.
Verify the file contains the translator comments "placeholder text used for the citation" and "placeholder text used for the quote" (a search for the strings is enough to check, in master it does not contain the translator comments).