Media & Text: Add field that allows changing image alt text from the sidebar#11073
Merged
Conversation
Soean
approved these changes
Oct 25, 2018
Soean
left a comment
Member
There was a problem hiding this comment.
Thanks, the code looks fine and the alt text works in backend and frontend
👍
|
It should have full wide option. Many themes do this and if you plan to turn Gutenberg to visual theme editor this option is necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a field that allows changing the alt of the selected image on Media & Text block from the sidebar.
Fixes: #10924
How has this been tested?
I checked that I can correctly change the alt text of the image from the sidebar.
I checked that when a video is selected the alt text input field does not appear.
Screenshots