Skip to content

Add "Image Title Attribute" as an editable attribute on the image block#11070

Merged
mkaz merged 4 commits intoWordPress:masterfrom
brentswisher:add/image-block-title-attribute
Nov 1, 2019
Merged

Add "Image Title Attribute" as an editable attribute on the image block#11070
mkaz merged 4 commits intoWordPress:masterfrom
brentswisher:add/image-block-title-attribute

Conversation

@brentswisher
Copy link
Copy Markdown
Contributor

@brentswisher brentswisher commented Oct 25, 2018

Description

Closes #11054.

Adds a title attribute to the image block, as requestions in #11054, although I think there may be some more discussion needed, I will follow up there.

How has this been tested?

Add a new image block to the page either via dropping a file of the media library
Open the settings for that block.
See that there is now a "title" attribute that is defaulted to the current title attribute in the media library
Save and view post, see that the title attribute exists on the image unless it was set to blank.

Screenshots

edit_post_ gutenberg_dev _wordpress

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Image Affects the Image Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image block: allow for editing image title