Blocks: Merge parsed attributes on top of default attributes, instead of reverse#1087
Merged
westonruter merged 2 commits intomasterfrom Jun 16, 2017
Merged
Conversation
aduth
approved these changes
Jun 9, 2017
Member
aduth
left a comment
There was a problem hiding this comment.
Good catch. 👍 Pushed a unit test revision which would have failed on the previous implementation to help protect against future regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempting to change the
postsToShowin the Latest Posts block (#870) via manipulating the block's raw attributes (since there is no UI yet in the inspector), but each time I switched back to the Visual tab the number I entered would get reset to the default. It seems the order ofdefaultAttributesvsattributesis reversed ingetBlockAttributes.