Cover Image block: move edit function into separate file + code cleanup#10582
Closed
ZebulanStanphill wants to merge 1 commit intoWordPress:masterfrom
ZebulanStanphill:update/cover-image-edit-split
Closed
Cover Image block: move edit function into separate file + code cleanup#10582ZebulanStanphill wants to merge 1 commit intoWordPress:masterfrom ZebulanStanphill:update/cover-image-edit-split
ZebulanStanphill wants to merge 1 commit intoWordPress:masterfrom
ZebulanStanphill:update/cover-image-edit-split
Conversation
Member
Author
|
Closing in favor of #10758 and planned future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR splits the
editfunction of the Cover Image block into a separate file. It also does some code cleanup to the Cover Imageindex.jsandedit.js.Types of changes
editfunction split off fromcover-image/index.jsto newcover-image/edit.js.index.jsandedit.jsreorganized alphabetically.index.jsreorganized alphabetically.getEditWrapperPropsinindex.jsnow usesArray.prototype.includesinstead of the slightly-less-readableArray.prototype.indexOf.Testing instructions
There should be no difference in behavior compared to
master.