-
Notifications
You must be signed in to change notification settings - Fork 4.8k
a11y: revision button lacks sufficient context #78138
Copy link
Copy link
Closed
Labels
Good First IssueAn issue that's suitable for someone looking to contribute for the first timeAn issue that's suitable for someone looking to contribute for the first time[Feature] HistoryHistory, undo, redo, revisions, autosave.History, undo, redo, revisions, autosave.[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Metadata
Metadata
Assignees
Labels
Good First IssueAn issue that's suitable for someone looking to contribute for the first timeAn issue that's suitable for someone looking to contribute for the first time[Feature] HistoryHistory, undo, redo, revisions, autosave.History, undo, redo, revisions, autosave.[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
✅ Done
StatusShow more project fields
Done
Description
In the post sidebar, the revision row includes a number on the button, clicking which switches to the revision diff editor.
Sighted users can understand that this is a revision number because the text "Revisions" is on the left side. However, for users who rely on screen readers, when they focus on the button, it is only announced as
{number} button, making it unclear what this button is for.This issue has likely existed for some time, but since a new visual revision diff will be introduced in 7.0, it might be worth fixing in the 7.0 release.
This issue should be resolvable by adding an aria-label in addition to the visual text. Similar efforts are underway in other panels.
Perhaps a label like
Open revisions screen: {revision_number} revisionswould be appropriate.Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Please confirm which theme type you used for testing.