-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Theme: Update typography token naming #76838
Copy link
Copy link
Closed
Labels
[Package] Theme/packages/theme/packages/theme[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Metadata
Metadata
Assignees
Labels
[Package] Theme/packages/theme/packages/theme[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
💫 Done
Task: Rename typography tokens.
Background:
Typography tokens are defined in
typography.jsonunder thewpds-fontgrouping.This continues discussion from:
As discussed, the current naming is problematic because properties like line-height and prospective tokens like letter-spacing are not aspects of font. There's also an inconsistency between the file name and the property grouping.
Last this left off, there was a "relatively strong preference" from @mirka toward naming these tokens
typography. Unclear if @ciampo 's " 👍 " reaction is directed to this suggestion. I'm personally fine with it.