Skip to content

Improve color indicators in style previews #59444

@richtabor

Description

@richtabor

Related to this comment by @ramonjd, I propose we adapt how the highlightedColors are chosen for style variations and associated UI. This way it's a clearer visual of the actual colors applied from the variation.

I'm thinking the first indicator should be the text color, with the second using the button color. If there's no button color, it would fallback to the text color, which is fine, as that variation may be more minimal. There would always be two indicators, maintaining consistency in the UI, reducing confusion.

This would also ensure that the color indicators have appropriate contrast values, as they are styled with the same values that are expected to have a high contrast value against the variation's background color.

These indicator colors should be the same for full theme style variations as well, not just instances of these 'mini' selectors.

CleanShot 2024-02-28 at 17 29 32

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions