-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Improve color indicators in style previews #59444
Copy link
Copy link
Closed
Labels
[Feature] Theme Style VariationsRelated to style variations provided by block themesRelated to style variations provided by block themes[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Metadata
Metadata
Assignees
Labels
[Feature] Theme Style VariationsRelated to style variations provided by block themesRelated to style variations provided by block themes[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Related to this comment by @ramonjd, I propose we adapt how the
highlightedColorsare chosen for style variations and associated UI. This way it's a clearer visual of the actual colors applied from the variation.I'm thinking the first indicator should be the text color, with the second using the button color. If there's no button color, it would fallback to the text color, which is fine, as that variation may be more minimal. There would always be two indicators, maintaining consistency in the UI, reducing confusion.
This would also ensure that the color indicators have appropriate contrast values, as they are styled with the same values that are expected to have a high contrast value against the variation's background color.
These indicator colors should be the same for full theme style variations as well, not just instances of these 'mini' selectors.