Skip to content

MediaReplaceFlow: layout regression #58593

@t-hamano

Description

@t-hamano

Description

It appears that recent changes made in the LinkControl component have caused a regression in the layout of the MediaReplaceFlow component.

As far as I researched, the two PRs, #57775 and #57608, are related.


⚒️ Before #57775 is merged

commit_27fc84e0

This should be the expected layout.


⚠️ After #57775 was merged

commit_614e0355

  • The icon and URL are misaligned.
  • The background color of the icon may also not be what we intended.
  • Also, this may be a Windows OS-specific problem, but the text descender is cut off.

✅ After #57608 was merged

Fixed by #58597

image

  • A scroll bar will appear.

These changes are in the Gutenberg version that ships to WP6.5, and I think they need to be fixed, so I'll add them to the editor task for WP6.5.

Step-by-step reproduction instructions

  • Insert an Image block
  • Add media.
  • Click "Replace" button.

Metadata

Metadata

Assignees

Labels

[Feature] Link EditingLink components (LinkControl, URLInput) and integrations (RichText link formatting)[Feature] MediaAnything that impacts the experience of managing media[Status] In ProgressTracking issues with work in progress[Type] RegressionRelated to a regression in the latest release

Type

No type
No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions